Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] added full_stops #1465

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

bhargavshirin
Copy link
Contributor

🔬 Background

  • Why is this change needed? Is there a related issue or a new feature to be added?
    for the better documentation.

🔮 Key changes

   added full_stops for sentences.
  • Explain the main changes introduced by this pull request for the reviewer.
    added full_stops in the end of sentences in readme.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #1465 (3400fa6) into main (70961d3) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1465   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          38       38           
  Lines        5097     5097           
=======================================
  Hits         4502     4502           
  Misses        595      595           

@SimonWittner SimonWittner merged commit ee8d886 into ourownstory:main Nov 2, 2023
10 of 12 checks passed
@ourownstory ourownstory changed the title added full_stops [docs] added full_stops Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants