[minor] add subdivisions to holidays

[MaiBe-ctrl]

🔬 Background

• closes add_country_holidays is missing subdivisions #1574

🔮 Key changes

• Explain the main changes introduced by this pull request for the reviewer.

📋 Review Checklist

• I have performed a self-review of my own code.
• I have commented my code, added docstrings and data types to function definitions.
• I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

[MaiBe-ctrl]

chnage the country parameter to accept a dict or str to list and omit the new added parameter!

[ourownstory]

merge get_country_holidays into get_holidays_from_country and move to hdays_utils

[ourownstory]

Looking good overall! I just suggest to move the get_holidays_from_country to hday_utils.py

[ourownstory]

self does not appear to be accessed in this method. I think we can safely move it to hdays_utils.py.

[ourownstory]

@MaiBe-ctrl Looks like you missed one utility function that was in time_dataset.py. I moved it to hday_utils.py. It was also not supporting subdivisions, so I added support for that, too. There is a lot of simplification potential to reduce the code in hday_utils.py, but we can leave that for the refactoring post-JIT.

[ourownstory]

Feel free to merge once tests pass.

[github-actions]

Model Benchmark

Benchmark	Metric	main	current	diff
PeytonManning	MAE_val	0.34955	0.34955	0.0%	✅
PeytonManning	RMSE_val	0.50049	0.50049	0.0%	✅
PeytonManning	Loss_val	0.01771	0.01771	0.0%	✅
PeytonManning	MAE	0.34653	0.34653	0.0%	✅
PeytonManning	RMSE	0.49312	0.49312	0.0%	✅
PeytonManning	Loss	0.01464	0.01464	0.0%	✅
PeytonManning	time	14.7847	14.99	1.39%	✅
AirPassengers	MAE_val	30.6285	30.6285	0.0%	✅
AirPassengers	RMSE_val	31.5254	31.5254	0.0%	✅
AirPassengers	Loss_val	0.01277	0.01277	0.0%	✅
AirPassengers	MAE	6.16861	6.16861	0.0%	✅
AirPassengers	RMSE	7.85225	7.85225	0.0%	✅
AirPassengers	Loss	0.00065	0.00065	0.0%	✅
AirPassengers	time	9.24684	9.56	3.39%	⚠️
EnergyPriceDaily	MAE_val	5.41157	5.41157	0.0%	✅
EnergyPriceDaily	RMSE_val	6.71538	6.71538	0.0%	✅
EnergyPriceDaily	Loss_val	0.02525	0.02525	0.0%	✅
EnergyPriceDaily	MAE	5.94936	5.94936	0.0%	✅
EnergyPriceDaily	RMSE	7.9833	7.9833	0.0%	✅
EnergyPriceDaily	Loss	0.02579	0.02579	0.0%	✅
EnergyPriceDaily	time	18.5817	18.47	-0.6%	✅
YosemiteTemps	MAE_val	0.56412	0.56412	0.0%	✅
YosemiteTemps	RMSE_val	0.83161	0.83161	0.0%	✅
YosemiteTemps	Loss_val	0.0004	0.0004	0.0%	✅
YosemiteTemps	MAE	0.98449	0.98449	0.0%	✅
YosemiteTemps	RMSE	1.75389	1.75389	0.0%	✅
YosemiteTemps	Loss	0.00132	0.00132	0.0%	✅
YosemiteTemps	time	39.8691	40.32	1.13%	✅

\n

Model training plots

\n ## Model Training ### PeytonManning  ### YosemiteTemps  ### AirPassengers  ### EnergyPriceDaily  \n