Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Raise Error if ar_reg is set an dn_lags is null #1588

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

MaiBe-ctrl
Copy link
Collaborator

🔬 Background

-fixes #1560

🔮 Key changes

  • Explain the main changes introduced by this pull request for the reviewer.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

Copy link

github-actions bot commented Jun 20, 2024

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.34955 0.34955 0.0%
PeytonManning RMSE_val 0.50049 0.50049 0.0%
PeytonManning Loss_val 0.01771 0.01771 0.0%
PeytonManning MAE 0.34653 0.34653 0.0%
PeytonManning RMSE 0.49312 0.49312 0.0%
PeytonManning Loss 0.01464 0.01464 0.0%
PeytonManning time 14.189 14.38 1.35%
AirPassengers MAE_val 30.6285 30.6285 0.0%
AirPassengers RMSE_val 31.5254 31.5254 0.0%
AirPassengers Loss_val 0.01277 0.01277 0.0%
AirPassengers MAE 6.16861 6.16861 0.0%
AirPassengers RMSE 7.85225 7.85225 0.0%
AirPassengers Loss 0.00065 0.00065 0.0%
AirPassengers time 9.13176 9.11 -0.24%
EnergyPriceDaily MAE_val 5.41157 5.41157 0.0%
EnergyPriceDaily RMSE_val 6.71538 6.71538 0.0%
EnergyPriceDaily Loss_val 0.02525 0.02525 0.0%
EnergyPriceDaily MAE 5.94936 5.94936 0.0%
EnergyPriceDaily RMSE 7.9833 7.9833 0.0%
EnergyPriceDaily Loss 0.02579 0.02579 0.0%
EnergyPriceDaily time 16.8187 17.53 4.23% ⚠️
YosemiteTemps MAE_val 0.56412 0.56412 0.0%
YosemiteTemps RMSE_val 0.83161 0.83161 0.0%
YosemiteTemps Loss_val 0.0004 0.0004 0.0%
YosemiteTemps MAE 0.98449 0.98449 0.0%
YosemiteTemps RMSE 1.75389 1.75389 0.0%
YosemiteTemps Loss 0.00132 0.00132 0.0%
YosemiteTemps time 39.6227 38.23 -3.51%
\nModel training plots\n ## Model Training ### PeytonManning ![](https://asset.cml.dev/5f078aea256be5f0f77c88312ad33d1aca9ee0a6?cml=svg%2Bxml&cache-bypass=d6552066-c76e-43c4-8e26-7238be0aaf9e) ### YosemiteTemps ![](https://asset.cml.dev/5d80200370a2aa9ba82f9c82d1ca697a9c97c3d1?cml=svg%2Bxml&cache-bypass=d4624051-41c0-423e-bdef-189a6b65fcf8) ### AirPassengers ![](https://asset.cml.dev/2975af57f3c49cdbcb032381ba0c75c80a8fd44d?cml=svg%2Bxml&cache-bypass=25b953c9-7088-493a-9722-7cd86361d69f) ### EnergyPriceDaily ![](https://asset.cml.dev/d4ecde1a348413707be68e5ebc10da87ba1a9f31?cml=svg%2Bxml&cache-bypass=9b93b9d9-f577-40ab-ace6-ec0ce5f3e7ea) \n

@ourownstory ourownstory merged commit 711b30a into main Jun 20, 2024
6 of 11 checks passed
@ourownstory ourownstory deleted the bug/1560--add-warning-ar_reg-and-lags branch June 20, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'TimeNet' object has no attribute 'ar_weights' in model.fit() when n_lags is not set but ar_reg is set
2 participants