Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias function plot_last_forecast() for plot_latest_forecast() and give deprecation warning #919

Merged
merged 11 commits into from
Nov 21, 2022
Merged

Add alias function plot_last_forecast() for plot_latest_forecast() and give deprecation warning #919

merged 11 commits into from
Nov 21, 2022

Conversation

judussoari
Copy link
Collaborator

@judussoari judussoari commented Oct 28, 2022 •
edited
Loading

Fixes #906

@judussoari
Add alias function plot_last_forecast()
d54dc57 
*Calls plot_latest and gives deprecation warning
@judussoari
Add alias function plot_last_forecast()
776bdee 
*Calls plot_latest and gives deprecation warning
@judussoari judussoari added this to the Release 0.4.2 milestone Oct 28, 2022
@judussoari judussoari self-assigned this Oct 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #919 (32d19c2) into main (cce32c0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   87.41%   87.42%   +0.01%     
==========================================
  Files          17       17              
  Lines        4464     4468       +4     
==========================================
+ Hits         3902     3906       +4     
  Misses        562      562
Impacted Files Coverage Δ
neuralprophet/forecaster.py 87.99% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@judussoari judussoari added the type:bug Something isn't working label Oct 28, 2022
@judussoari judussoari added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 7, 2022
@Kevin-Chen0
Copy link
Collaborator

Please fix metrics test.

@Kevin-Chen0 Kevin-Chen0 added status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 17, 2022
@judussoari judussoari added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved labels Nov 18, 2022
Kevin-Chen0
Kevin-Chen0 approved these changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@Kevin-Chen0 Kevin-Chen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neuralprophet/forecaster.py
args = locals()
log.warning(
"plot_last_forecast() has been renamed to plot_latest_forecast() and is therefore deprecated. "
"Please use plot_latst_forecast() in the future"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please use plot_latest_forecast()* in the future"

@Kevin-Chen0 Kevin-Chen0 added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 19, 2022
ourownstory
ourownstory approved these changes Nov 21, 2022
View reviewed changes
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ourownstory ourownstory merged commit 8a59a1d into ourownstory:main Nov 21, 2022
@github-actions
Copy link

8a59a1d

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0% ✅
AirPassengers RMSE_val 19.4209 19.4209 0.0% ✅
AirPassengers Loss_val 0.00195 0.00195 0.0% ✅
AirPassengers RegLoss_val 0 0 0.0% ✅
AirPassengers epoch 89 89 0.0% ✅
AirPassengers MAE 9.82902 9.82902 0.0% ✅
AirPassengers RMSE 11.7005 11.7005 0.0% ✅
AirPassengers Loss 0.00056 0.00056 0.0% ✅
AirPassengers RegLoss 0 0 0.0% ✅
PeytonManning MAE_val 0.64636 0.64636 0.0% ✅
PeytonManning RMSE_val 0.79276 0.79276 0.0% ✅
PeytonManning Loss_val 0.01494 0.01494 0.0% ✅
PeytonManning RegLoss_val 0 0 0.0% ✅
PeytonManning epoch 37 37 0.0% ✅
PeytonManning MAE 0.42701 0.42701 0.0% ✅
PeytonManning RMSE 0.57032 0.57032 0.0% ✅
PeytonManning Loss 0.00635 0.00635 0.0% ✅
PeytonManning RegLoss 0 0 0.0% ✅
YosemiteTemps MAE_val 1.72949 1.72949 0.0% ✅
YosemiteTemps RMSE_val 2.27386 2.27386 0.0% ✅
YosemiteTemps Loss_val 0.00096 0.00096 0.0% ✅
YosemiteTemps RegLoss_val 0 0 0.0% ✅
YosemiteTemps epoch 84 84 0.0% ✅
YosemiteTemps MAE 1.45189 1.45189 0.0% ✅
YosemiteTemps RMSE 2.16631 2.16631 0.0% ✅
YosemiteTemps Loss 0.00066 0.00066 0.0% ✅
YosemiteTemps RegLoss 0 0 0.0% ✅

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@judussoari judussoari deleted the alias_func branch November 22, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevin-Chen0 Kevin-Chen0 Kevin-Chen0 approved these changes

@ourownstory ourownstory ourownstory approved these changes

Assignees

@judussoari judussoari

Labels
status: ready PR is ready to be merged type:bug Something isn't working
Projects
None yet
Milestone
Release Candidate 0.5.0rc1
Development

Successfully merging this pull request may close these issues.

[UI] add plot_last alias for renamed function (backwards compatiblitity)
4 participants
@judussoari @codecov-commenter @Kevin-Chen0 @ourownstory