Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for df dict as an input #929

Merged
merged 8 commits into from
Nov 21, 2022
Merged

Remove support for df dict as an input #929

merged 8 commits into from
Nov 21, 2022

Conversation

judussoari
Copy link
Collaborator

*Before: we issued a warning saying df dict as an input will be deprecated soon

*Now for 0.5.0: Raise ValueError, because it is no longer supported

*NP requires pd.DataFrame, optionally with ID column specifying the presence of > 1 time series

closes #810

@judussoari
Remove support for df dict as an input
b8fd7a4 
*Before: we issued a warning saying df dict input will be deprecated soon

*Now for 0.5.0: Raise ValueError, because it is no longer supported

*NP requires pd.DataFrame, optionally with ID column specifying the presence of > 1 time series
@judussoari judussoari added this to the Release 0.5.0 milestone Nov 2, 2022
@judussoari judussoari self-assigned this Nov 2, 2022
@judussoari
Remove support for df dict as an input
56d13c5 
*Before: we issued a warning saying df dict input will be deprecated soon

*Now for 0.5.0: Raise ValueError, because it is no longer supported

*NP requires pd.DataFrame, optionally with ID column specifying the presence of > 1 time series
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022 •
edited
Loading

Codecov Report

Merging #929 (6a20280) into main (cce32c0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   87.41%   87.37%   -0.04%     
==========================================
  Files          17       17              
  Lines        4464     4451      -13     
==========================================
- Hits         3902     3889      -13     
  Misses        562      562
Impacted Files Coverage Δ
neuralprophet/df_utils.py 94.72% <100.00%> (-0.13%) ⬇️
neuralprophet/forecaster.py 87.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@judussoari judussoari added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 7, 2022
noxan
noxan approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, great job :)

We should make clear there is a breaking change due to the removed dict support.

@noxan noxan added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 7, 2022
@Kevin-Chen0
Copy link
Collaborator

Hi @judussoari,

Apologies that this PR is left hanging:

  • Can you resolve the conflicts with main?
  • Can you check why the metrics are failing?

Thanks.

@Kevin-Chen0 Kevin-Chen0 added status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved and removed status: ready PR is ready to be merged labels Nov 15, 2022
@judussoari judussoari added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved labels Nov 18, 2022
ourownstory
ourownstory approved these changes Nov 21, 2022
View reviewed changes
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ourownstory ourownstory merged commit 567bc7f into ourownstory:main Nov 21, 2022
@github-actions
Copy link

567bc7f

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0% ✅
AirPassengers RMSE_val 19.4209 19.4209 0.0% ✅
AirPassengers Loss_val 0.00195 0.00195 0.0% ✅
AirPassengers RegLoss_val 0 0 0.0% ✅
AirPassengers epoch 89 89 0.0% ✅
AirPassengers MAE 9.82902 9.82902 0.0% ✅
AirPassengers RMSE 11.7005 11.7005 0.0% ✅
AirPassengers Loss 0.00056 0.00056 0.0% ✅
AirPassengers RegLoss 0 0 0.0% ✅
PeytonManning MAE_val 0.64636 0.64636 0.0% ✅
PeytonManning RMSE_val 0.79276 0.79276 0.0% ✅
PeytonManning Loss_val 0.01494 0.01494 0.0% ✅
PeytonManning RegLoss_val 0 0 0.0% ✅
PeytonManning epoch 37 37 0.0% ✅
PeytonManning MAE 0.42701 0.42701 0.0% ✅
PeytonManning RMSE 0.57032 0.57032 0.0% ✅
PeytonManning Loss 0.00635 0.00635 0.0% ✅
PeytonManning RegLoss 0 0 0.0% ✅
YosemiteTemps MAE_val 1.72949 1.72949 0.0% ✅
YosemiteTemps RMSE_val 2.27386 2.27386 0.0% ✅
YosemiteTemps Loss_val 0.00096 0.00096 0.0% ✅
YosemiteTemps RegLoss_val 0 0 0.0% ✅
YosemiteTemps epoch 84 84 0.0% ✅
YosemiteTemps MAE 1.45189 1.45189 0.0% ✅
YosemiteTemps RMSE 2.16631 2.16631 0.0% ✅
YosemiteTemps Loss 0.00066 0.00066 0.0% ✅
YosemiteTemps RegLoss 0 0 0.0% ✅

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@judussoari judussoari deleted the rmv_dict_support branch November 22, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noxan noxan noxan approved these changes

@ourownstory ourownstory ourownstory approved these changes

Assignees

@judussoari judussoari

Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Milestone
Release Candidate 0.5.0rc1
Development

Successfully merging this pull request may close these issues.

[enhancement] remove support for dicts of df as input
5 participants
@judussoari @codecov-commenter @Kevin-Chen0 @noxan @ourownstory