-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typing] Add type annotations for main NeuralProphet class #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
noxan
commented
Nov 22, 2022
- Add more type annotations
Model BenchmarkShow benchmark results
Model TrainingPeytonManningYosemiteTempsAirPassengers |
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 87.91% 87.88% -0.03%
==========================================
Files 17 18 +1
Lines 4443 4450 +7
==========================================
+ Hits 3906 3911 +5
- Misses 537 539 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
noxan
changed the title
[typing] Add more type annotations
[typing] Add type annotations for main NeuralProphet class
Nov 23, 2022
noxan
force-pushed
the
typing/add-more-type-annotations
branch
from
November 23, 2022 01:41
5227e15
to
876d59f
Compare
Kevin-Chen0
requested changes
Nov 23, 2022
Kevin-Chen0
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kevin-Chen0
added
status: ready
PR is ready to be merged
and removed
status: needs review
PR needs to be reviewed by Reviewer(s)
labels
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.