Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing] Add type annotations for main NeuralProphet class #981

Merged
merged 31 commits into from
Nov 23, 2022

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Nov 22, 2022

  • Add more type annotations

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

c86a5d3

Model Benchmark

Show benchmark results
Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #981 (b3737b7) into main (bba5a67) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   87.91%   87.88%   -0.03%     
==========================================
  Files          17       18       +1     
  Lines        4443     4450       +7     
==========================================
+ Hits         3906     3911       +5     
- Misses        537      539       +2     
Impacted Files Coverage Δ
neuralprophet/configure.py 89.81% <100.00%> (-0.76%) ⬇️
neuralprophet/forecaster.py 88.05% <100.00%> (-0.07%) ⬇️
neuralprophet/np_types.py 100.00% <100.00%> (ø)
neuralprophet/utils.py 80.06% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 23, 2022
@noxan noxan changed the title [typing] Add more type annotations [typing] Add type annotations for main NeuralProphet class Nov 23, 2022
@noxan noxan force-pushed the typing/add-more-type-annotations branch from 5227e15 to 876d59f Compare November 23, 2022 01:41
neuralprophet/configure.py Show resolved Hide resolved
neuralprophet/configure.py Outdated Show resolved Hide resolved
neuralprophet/forecaster.py Show resolved Hide resolved
Copy link
Collaborator

@Kevin-Chen0 Kevin-Chen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kevin-Chen0 Kevin-Chen0 added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 23, 2022
@noxan noxan merged commit c86a5d3 into main Nov 23, 2022
@noxan noxan deleted the typing/add-more-type-annotations branch November 23, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants