Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing] Resolve type annotation issues in configure file #987

Merged
merged 10 commits into from
Nov 30, 2022

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Nov 24, 2022

Resolve type annotation issues in configure file and ignore epochs None type warning due to almost impossible to fix with dataclasses - see [source]

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #987 (7884858) into main (f9a1fb6) will increase coverage by 0.10%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   89.72%   89.82%   +0.10%     
==========================================
  Files          18       18              
  Lines        4611     4631      +20     
==========================================
+ Hits         4137     4160      +23     
+ Misses        474      471       -3     
Impacted Files Coverage Δ
neuralprophet/configure.py 90.15% <85.71%> (+0.82%) ⬆️
neuralprophet/forecaster.py 88.01% <100.00%> (ø)
neuralprophet/hdays.py 99.72% <0.00%> (+<0.01%) ⬆️
neuralprophet/df_utils.py 94.72% <0.00%> (+<0.01%) ⬆️
neuralprophet/time_net.py 90.01% <0.00%> (+0.07%) ⬆️
neuralprophet/logger.py 100.00% <0.00%> (+4.34%) ⬆️
neuralprophet/np_types.py 100.00% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

d347096

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%
YosemiteTemps time 101.45 93.44 -7.9%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
PeytonManning time 12.4 11.72 -5.48%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
AirPassengers time 4.85 4.51 -7.01%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 24, 2022
@noxan noxan self-assigned this Nov 28, 2022
Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the comments in configure.py? Otherwise lgtm

neuralprophet/configure.py Show resolved Hide resolved
neuralprophet/configure.py Outdated Show resolved Hide resolved
neuralprophet/configure.py Show resolved Hide resolved
@karl-richter karl-richter added status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 30, 2022
@noxan noxan added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved labels Nov 30, 2022
Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noxan noxan merged commit d347096 into main Nov 30, 2022
@noxan noxan deleted the typing/resolve-configure-file branch November 30, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants