-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typing] Resolve type annotation issues in configure file #987
Conversation
Codecov Report
@@ Coverage Diff @@
## main #987 +/- ##
==========================================
+ Coverage 89.72% 89.82% +0.10%
==========================================
Files 18 18
Lines 4611 4631 +20
==========================================
+ Hits 4137 4160 +23
+ Misses 474 471 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Model Benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the comments in configure.py? Otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolve type annotation issues in configure file and ignore epochs
None
type warning due to almost impossible to fix withdataclasses
- see [source]