-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time in model training benchmark #995
Conversation
@Kevin-Chen0 @ourownstory @noxan |
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 18 18
Lines 4632 4632
=======================================
Hits 4160 4160
Misses 472 472 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one minor comment on collapsible metrics - ready to merge from my side.
python tests/metrics/compareMetrics.py >> report.md | ||
- name: Publish report | ||
env: | ||
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
echo "<details>\n<summary>Model training plots</summary>\n" >> report.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to have an option to also collapse the regular metrics - no hard feelings and no blocker for sure 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally, agree, in the current setting there are too many metrics. Lets agree in our weekly meeting on the few key metrics that we always display and make all the others collabsable. I am just afraid that people do not check their metrics if its not visible that their pr reduces performance.
Added training time to the benchmarks + only hide the figures, but not the metrics.