forked from hyperledger/cacti
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build(docs/examples): add yarn patch to @Ionic deps of example frontend
1. The `main` field of the package.json of these two packages were invalid because the `main` field was set to `bundle.js` but that file is actually under `ngx/bundle.js` within the package directory and therefore the value of it originally was invalid that caused warnings in our tooling. 2. By using the yarn **patch** feature we overcame this problem by modifying the sources of the dependencies in question: `@ionic-native/splash-screen` and `@ionic-native/status-bar` Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
- Loading branch information
Showing
6 changed files
with
873 additions
and
545 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.yarn/patches/@ionic-native-splash-screen-npm-5.36.0-531cbbe0f8.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| diff --git a/package.json b/package.json | ||
| index 93048af66b6ae275006be0eb70a0d06ee606b67f..3d4d2ff657475a98f16ed23778e33e09f78d850a 100644 | ||
| --- a/package.json | ||
| +++ b/package.json | ||
| @@ -1 +1 @@ | ||
| -{"description":"Ionic Native - Native plugins for ionic apps","main":"bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/splash-screen","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"} | ||
| +{"description":"Ionic Native - Native plugins for ionic apps","main":"ngx/bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/splash-screen","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"} |
7 changes: 7 additions & 0 deletions
7
.yarn/patches/@ionic-native-status-bar-npm-5.36.0-1ca86cbaad.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| diff --git a/package.json b/package.json | ||
| index 2f7070b3e70fd5b9e013e3a707b589bad7f984f1..bc0094f00ef993e32e1b4a79fbb894d4780f0b92 100644 | ||
| --- a/package.json | ||
| +++ b/package.json | ||
| @@ -1 +1 @@ | ||
| -{"description":"Ionic Native - Native plugins for ionic apps","main":"bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/status-bar","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"} | ||
| +{"description":"Ionic Native - Native plugins for ionic apps","main":"ngx/bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/status-bar","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
02efca0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
0.25.cmd-api-server_HTTP_GET_getOpenApiSpecV1588ops/sec (±1.65%)563ops/sec (±1.65%)0.96cmd-api-server_gRPC_GetOpenApiSpecV1357ops/sec (±1.22%)348ops/sec (±1.34%)0.97This comment was automatically generated by workflow using github-action-benchmark.
CC: @petermetz