ldmsd hanging on delete_thread fix #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ldmsd aggregators on one of our production clusters would enter into a deadlock state waiting on
delete_threadindefinitely, where the aggregator daemon continued to run, would use 100% cpu, and in gdb session with a debug-symbol supported aggregator daemon instance, we discovered the issue manifests inldms/src/core/ldms.cwhere an if statement lacked a test to confirm success of red/black node relationship, (?).I'm proposing adding in this code-fix for this issue we continue to encounter on Sandia systems after debug session on tag release v4.4.3 with @tom95858, on aggregators without the patch.
@bschwal