Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add text labels to bottom nav bar #4484

Open
tbsbdr opened this issue Oct 1, 2024 · 1 comment · May be fixed by #4497
Open

[FEATURE REQUEST] Add text labels to bottom nav bar #4484

tbsbdr opened this issue Oct 1, 2024 · 1 comment · May be fixed by #4497

Comments

@tbsbdr
Copy link

tbsbdr commented Oct 1, 2024

Problem
Icons without text labels can be unclear. see also https://www.nngroup.com/articles/icon-usability/
(I suspect especially the Spaces and Shares icon to be not 100% at first glance)

Proposed solution

  • Add text labels to the bottom nav bar
  • Add active state (eg. "icon background pill")
  • tbd: in order to reduce noise, we could discuss to remove a navitem eg. the offline item - to be discussed

android bottom nav bar

@JuancaG05 @jesmrec would you say that the proposal is an improvement compared to the current implementation?

@JuancaG05
Copy link
Collaborator

Hi @tbsbdr! Cool! Yes, this could be a nice improvement. We'd follow Material Design guidelines by adding the labels (https://m3.material.io/components/navigation-bar/guidelines#be759d91-d920-4779-9856-44869ad25091) and the active indicator (https://m3.material.io/components/navigation-bar/guidelines#935d4e62-b4e8-4d5e-8b87-6a39ec479c85), so it's a big yes from my side 💯

@JuancaG05 JuancaG05 changed the title [FR] Add text labels to bottom nav bar [FEATURE REQUEST] Add text labels to bottom nav bar Oct 4, 2024
@jesmrec jesmrec added this to the 4.5 - Next milestone Oct 4, 2024
@JuancaG05 JuancaG05 self-assigned this Oct 7, 2024
@JuancaG05 JuancaG05 linked a pull request Oct 7, 2024 that will close this issue
@JuancaG05 JuancaG05 removed a link to a pull request Oct 11, 2024
@JuancaG05 JuancaG05 linked a pull request Oct 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants