-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add text labels bottom nav bar #4497
base: master
Are you sure you want to change the base?
Feature/add text labels bottom nav bar #4497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yogeshjindal! Thanks for this new PR! Let's take a look at the points I highlighted in the previous one:
- Branch naming is perfect! ✅
- Conventional commits are not well used here. There are 4 commits, of which 3 are not useful. We only need the second one, that should be named
feat: added text labels and active indicator to BottomNavigationView
(for example) to follow the convention. I recommend removing those 3 non-necessary commits to avoid confusions (see the comment below), seems you were importing some Material stuff that you didn't need in the end 👍. - Check the comments I added about the Calens file and fix it 😄
- There's also a release note to add. To do this, you just have to add a new
ReleaseNote
object to the list inReleaseNoteViewModel.kt
, creating new strings for that
Feel free to open a new PR or correcting it in this same branch. In the next comment I'll show you how to remove commits 👍
A quick explanation about removing commits so that you learn for a future too:
The number that goes together with
After this, you should have in this PR only the commits we want and I'll be able to review it again 😊 |
@JuancaG05 Sir,Thanks a lot for sharing this valuable information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yogeshjindal, check this new CR round I made. Conventional commits are not correctly used yet, I insist on following the instructions I posted in the message above to remove commits that are not needed 👍.
Also, this needs a rebase against master
, there was new content added there.
@@ -832,5 +832,7 @@ | |||
<string name="audio_preview_label">Audio preview</string> | |||
<string name="details_label">Details</string> | |||
<string name="text_preview_label">Text preview</string> | |||
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom nav bar</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be read by all users, so let's not use technical language. Bottom bar is OK 👍
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom nav bar</string> | |
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom bar</string> |
@@ -832,5 +832,7 @@ | |||
<string name="audio_preview_label">Audio preview</string> | |||
<string name="details_label">Details</string> | |||
<string name="text_preview_label">Text preview</string> | |||
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom nav bar</string> | |||
<string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which label is selected on the bottom nav bar</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which label is selected on the bottom nav bar</string> | |
<string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which section is selected on the bottom bar</string> |
owncloudApp/build.gradle
Outdated
@@ -34,7 +34,7 @@ dependencies { | |||
implementation libs.androidx.work.runtime.ktx | |||
implementation(libs.androidx.browser) { because "CustomTabs required for OAuth2 and OIDC" } | |||
implementation(libs.androidx.enterprise.feedback) { because "MDM feedback" } | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are keeping this change, it's not needed
Added text labels to the bottom nav bar
Used default activeStateIndicator which will show which label is selected
Now, all the items in nav bar shows the labels and upon selection the activeIndicator is enabled which shows that which item is selected.
Fix#4484