Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add text labels bottom nav bar #4497

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+15 −1
Open

Feature/add text labels bottom nav bar #4497

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
909137a
modified bottom-nav-bar
Yogeshjindal Oct 5, 2024
e16a35a
feat/bottom_nav_bar: Added text labels and active indicator to Bottom…
Yogeshjindal Oct 11, 2024
ed93b31
Update build.gradle
Yogeshjindal Oct 11, 2024
3bf9fc3
Update libs.versions.toml
Yogeshjindal Oct 11, 2024
1389ad6
feat/bottom_nav_bar: Updated implementation for text labels and activ…
Yogeshjindal Oct 11, 2024
e1047c1
Update build.gradle
Yogeshjindal Oct 11, 2024
8a5494d
Merge branch 'master' into feature/add-text-labels-bottom-nav-bar
Yogeshjindal Oct 14, 2024
ace3e7f
Update strings.xml
Yogeshjindal Oct 14, 2024
aaa9c1a
Update build.gradle
Yogeshjindal Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/4484
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Added text labels for BottomNavigationView

Text labels have been added below the icons, and the active indicator feature is implemented using the default itemActiveIndicatorStyle for better navigation experience.


https://github.com/owncloud/android/issues/4484
https://github.com/owncloud/android/pull/4497
2 changes: 1 addition & 1 deletion owncloudApp/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies {
implementation libs.androidx.work.runtime.ktx
implementation(libs.androidx.browser) { because "CustomTabs required for OAuth2 and OIDC" }
implementation(libs.androidx.enterprise.feedback) { because "MDM feedback" }

JuancaG05 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are keeping this change, it's not needed

// Image loading
implementation libs.coil
implementation libs.glide
Expand Down
5 changes: 5 additions & 0 deletions ...App/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ class ReleaseNotesViewModel(
subtitle = R.string.release_notes_bugfixes_subtitle,
type = ReleaseNoteType.BUGFIX
),
ReleaseNote(
title = R.string.release_notes_title_enhanced_bottom_nav_bar,
subtitle = R.string.release_notes_subtitle_bottom_nav_bar,
type = ReleaseNoteType.ENHANCEMENT
),
)
}
}
2 changes: 1 addition & 1 deletion owncloudApp/src/main/res/layout/nav_coordinator_layout.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@
android:visibility="visible"
app:itemIconTint="@color/primary_button_text_color"
app:itemTextColor="@color/primary_button_text_color"
app:labelVisibilityMode="auto"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:labelVisibilityMode="labeled"
app:menu="@menu/bottom_navbar_menu" />

</androidx.constraintlayout.widget.ConstraintLayout>
2 changes: 2 additions & 0 deletions owncloudApp/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,5 +832,7 @@
<string name="audio_preview_label">Audio preview</string>
<string name="details_label">Details</string>
<string name="text_preview_label">Text preview</string>
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom nav bar</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be read by all users, so let's not use technical language. Bottom bar is OK 👍

Suggested change
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom nav bar</string>
<string name="release_notes_title_enhanced_bottom_nav_bar">Added text labels on bottom bar</string>

<string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which label is selected on the bottom nav bar</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which label is selected on the bottom nav bar</string>
<string name="release_notes_subtitle_bottom_nav_bar">Text labels were added and default active indicator is used to show which section is selected on the bottom bar</string>


</resources>
Loading