Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Replace "auto-uploads" with "automatic uploads" #4492

Merged
merged 5 commits into from
Oct 9, 2024
Merged

[FEATURE REQUEST] Replace "auto-uploads" with "automatic uploads" #4492

merged 5 commits into from
Oct 9, 2024

Conversation

jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Oct 8, 2024 •
edited by JuancaG05
Loading

Related Issues

App: #4252

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec linked an issue Oct 8, 2024 that may be closed by this pull request
[FEATURE REQUEST] Auto-uploads string in Settings #4252
Closed
@jesmrec jesmrec force-pushed the feature/change_auto_uploads_name branch from fbc15fd to 35445eb Compare October 8, 2024 09:01
@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 8, 2024 •
edited
Loading

Replace all "Camera uploads" or "Auto uploads" with "Automatic uploads", not only in the UI but also in the code.

Just one exception: names in file providers and database references were not change to prevent unnecessary migrations. Let me know if this is a good or a bad decision.

@jesmrec jesmrec force-pushed the feature/change_auto_uploads_name branch from 3fdd10e to 44e93ff Compare October 8, 2024 09:17
@jesmrec jesmrec force-pushed the feature/change_auto_uploads_name branch 3 times, most recently from b36fa17 to b558888 Compare October 8, 2024 11:13
@jesmrec jesmrec force-pushed the feature/change_auto_uploads_name branch from e5a3727 to ca13f4f Compare October 8, 2024 12:18
@jesmrec jesmrec marked this pull request as ready for review October 8, 2024 12:38
JuancaG05
JuancaG05 requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one detail @jesmrec 👍

owncloudApp/src/main/res/values/strings.xml Show resolved Hide resolved
@jesmrec jesmrec force-pushed the feature/change_auto_uploads_name branch from 68127a4 to 0ce097a Compare October 9, 2024 10:36
@jesmrec jesmrec requested a review from JuancaG05 October 9, 2024 10:51
@JuancaG05 JuancaG05 changed the title [FEATURE] Replace "auto-uploads" with "automatic uploads" [FEATURE REQUEST] Replace "auto-uploads" with "automatic uploads" Oct 9, 2024
JuancaG05
JuancaG05 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joragua
Copy link
Collaborator

joragua commented Oct 9, 2024 •
edited
Loading

Approved from my side. Everything works correctly 🚀

@jesmrec jesmrec merged commit 5350049 into master Oct 9, 2024
5 checks passed
@jesmrec jesmrec deleted the feature/change_auto_uploads_name branch October 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@joragua joragua Awaiting requested review from joragua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Auto-uploads string in Settings
3 participants
@jesmrec @joragua @JuancaG05