libsync: Fix compilation with TOKEN_AUTH_ONLY #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we cannot use QtGui in libsync. So this mostly disable the avatar from the account and the avatarjob Note that there is one logic change: in ConnectionValidator::slotUserFetched we do the avatar job even if the user is empty. Otherwise we would end up in a invalid state. This restore the 2.3.x behavior that was broken in commit e05d6bf
|
Looks Ok but i'd like @ckamm to review this because of the reportResult change |
guruz
approved these changes
Nov 25, 2017
|
Thanks for fixing! I didn't know TOKEN_AUTH required not using QtGui in libsync. |
This was referenced May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we cannot use QtGui in libsync.
So this mostly disable the avatar from the account and the avatarjob
Note that there is one logic change: in ConnectionValidator::slotUserFetched
we do the avatar job even if the user is empty. Otherwise we would end up in
a invalid state. This restore the 2.3.x behavior that was broken in
commit e05d6bf