-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #40966 #40967
base: master
Are you sure you want to change the base?
Fix #40966 #40967
Conversation
Signed-off-by: Michiel de Jong <michiel@pondersource.com>
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
SonarCloud Quality Gate failed. 0 Bugs 22.2% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@michielbdejong somehow the CLA assistaqnt does not think that you have clicked the buttons to "sign" the CLA. I am surprised about that! But can you please click the button... |
@michielbdejong please also create a changelog for this. |
|
@@ -111,6 +111,25 @@ public function acceptShare($id) { | |||
); | |||
} | |||
|
|||
// Allow the Federated Groups app to overwrite the behaviour of this endpoint | |||
$managerClass = $this->config->getSystemValue('sharing.groupExternalManager'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some duplication getting the external manager. We can move that piece of code in a private method in order to reduce the duplication. I think this also affects to some code in this class not present in this PR.
No description provided.