Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document roles and permissions #268

Closed
wants to merge 1 commit into from
Closed

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Oct 20, 2022

Fixes: #207 (Document user roles concept/feature)

@mmattel mmattel added the documentation Improvements or additions to documentation label Oct 20, 2022
@mmattel mmattel force-pushed the roles_and_permissions branch 2 times, most recently from 79a266a to 18d47ba Compare October 24, 2022 15:20
@mmattel mmattel marked this pull request as ready for review October 24, 2022 15:21
@mmattel
Copy link
Contributor Author

mmattel commented Oct 25, 2022

@tbsbdr @kulmann @micbar
Finally, the PR is in a reviewable state. Could you please have a look on if things are correct.

@phil-davis though @EParzefall has already reviewed, mind to have a look on?

You can see a testbuild on staging which includes the review of @EParzefall

I am thinking about to add a note to the security aspects document with regards to roles and permissions, but will do that in another PR.

@mmattel mmattel force-pushed the roles_and_permissions branch 2 times, most recently from 7a2ff67 to 7a256d4 Compare October 26, 2022 08:46
@phil-davis phil-davis self-requested a review October 28, 2022 01:30
@mmattel mmattel marked this pull request as draft November 24, 2022 11:26
@mmattel
Copy link
Contributor Author

mmattel commented Nov 24, 2022

Converting to draft because one part is now in the webui documentation and the other part needs to be updated. Waiting for dev input on describing the permission types.

@mmattel
Copy link
Contributor Author

mmattel commented Jan 13, 2023

owncloud/ocis#5318 (graph: add appRoleAssignments and minimal application resource)

@mmattel
Copy link
Contributor Author

mmattel commented Jan 24, 2023

owncloud/ocis#5441 (Space Management Permissions)

@wkloucek wkloucek mentioned this pull request Mar 23, 2023
11 tasks
@phil-davis
Copy link
Contributor

Note: the "Guest" role was renamed to "User Light".
owncloud/ocis@fc80729
So any documentation of roles needs to have "User Light" (or maybe the technical string that is the role name is "UserLight"?)

@micbar
Copy link
Contributor

micbar commented Jun 21, 2023

@phil-davis Yes. "guest" was totally misleading.

  1. Roles are always about permissions
  2. User types (Member, Guest) are properties of the user

We need to make sure that these two things are not bound to each other.

@phil-davis
Copy link
Contributor

@micbar I want to clarify the terminology.
Where I said "the "Guest" role was renamed to "User Light"."
I should say "the "Guest" user type was renamed to "User Light"."

Is that correct?

@micbar
Copy link
Contributor

micbar commented Jun 21, 2023

@phil-davis no, you were correct. The role was renamed to avoid confusion.

Basically a user of type guest can have any role in ocis, even the "Admin" role.

@mmattel
Copy link
Contributor Author

mmattel commented Jul 18, 2024

Closing that PR as it is too outdated, we can recontinue if required.

@mmattel mmattel closed this Jul 18, 2024
@mmattel mmattel deleted the roles_and_permissions branch July 18, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document user roles concept/feature
4 participants