Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump core commit id for tests #2901

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 20, 2021

Description

This will get some new tests and test code from core into oCIS CI.

In particular, it gets the first iteration of webDAV personal spaces test code in place.

Related Issue

Part of owncloud/QA#703

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/8445/31/6

  Scenario Outline: upload a file and check download content                                             # /srv/app/testrunner/tests/acceptance/features/apiWebdavUpload1/uploadFile.feature:12
    Given using <dav_version> DAV path                                                                   # FeatureContext::usingOldOrNewDavPath()
    When user "Alice" uploads file with content "uploaded content" to "<file_name>" using the WebDAV API # FeatureContext::userUploadsAFileWithContentTo()
    Then the following headers should match these regular expressions for user "Alice"                   # FeatureContext::headersShouldMatchRegularExpressionsForUser()
      | ETag | /^"[a-f0-9:\.]{1,32}"$/ |
    And the content of file "<file_name>" for user "Alice" should be "uploaded content"                  # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | dav_version | file_name         |
      | old         | /upload.txt       |
      | old         | /नेपाली.txt       |
      | old         | /strängé file.txt |
      | new         | /upload.txt       |
      | new         | /strängé file.txt |
      | new         | /नेपाली.txt       |
      | old         | /s,a,m,p,l,e.txt  |
      | new         | /s,a,m,p,l,e.txt  |
      | spaces      | /upload.txt       |

The new spaces webDAV example passed. Good stuff. @kiranparajuli589 please double-check that the test is doing the right thing, accessing the personal space endpoint. Then we can talk about examples to add through the API tests for spaces

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 0718f96 into master Dec 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-core-commit-id-20211220 branch December 21, 2021 08:10
@micbar micbar mentioned this pull request Feb 16, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants