Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] experimental tags backport #5227

Merged
merged 2 commits into from
Dec 19, 2022
Merged

[full-ci] experimental tags backport #5227

merged 2 commits into from
Dec 19, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Dec 14, 2022

Description

Backport of experimental tags implementation, instead of using rest to access the tag endpoints this implementation is using graph to add these.

Related Issue

@update-docs
Copy link

update-docs bot commented Dec 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade force-pushed the tags-to-master branch 2 times, most recently from 6421460 to be08c4a Compare December 16, 2022 11:30
@fschade fschade marked this pull request as ready for review December 16, 2022 11:31
add tags getTags, AssignTags and UnassignTags endpoint to graph
use and prefer search event spaceOwner over executant
add tags to search report response
update libre graph api
update reva
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions...

services/graph/pkg/service/v0/tags.go Show resolved Hide resolved
services/graph/pkg/service/v0/tags.go Show resolved Hide resolved
services/graph/pkg/service/v0/tags.go Show resolved Hide resolved
services/graph/pkg/service/v0/tags.go Outdated Show resolved Hide resolved
services/graph/pkg/service/v0/tags.go Outdated Show resolved Hide resolved
services/graph/pkg/service/v0/tags.go Show resolved Hide resolved
services/graph/pkg/service/v0/tags.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

21.2% 21.2% Coverage
28.4% 28.4% Duplication

@fschade fschade merged commit 1db03dd into master Dec 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the tags-to-master branch December 19, 2022 14:44
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants