Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect global Envvars #5369

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jan 10, 2023

Compose a list of envvars living in more than 1 service

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@mmattel
Copy link
Contributor

mmattel commented Jan 10, 2023

We need to change in the adoc template file two things:

  • [width="100%",cols="30%,20%,~,~,~",options="header"]
    the first two columns need a fixed width
  • for the xref column only, a| [subs=attributes+]
    -attributes --> attributes+

image

Then, as you can see, we need, if possible two sortings 🙈

  • all services listed should be sorted alphabetical ascending
    see in the image above that the app-provider service is "somewhere" in the middle and therefore hard to identify. the list is usually looong.
  • if possible, the names of the envvars should be sorted ascending

@kobergj
Copy link
Collaborator Author

kobergj commented Jan 10, 2023

@mmattel yes good point 👍 I was not 100% sure what you mean by

if possible, the names of the envvars should be sorted ascending

so I sorted them alphabetically. Should I sort by number of services?
Rest is implemented as requested.

@mmattel
Copy link
Contributor

mmattel commented Jan 10, 2023

I'll check the result of the last change, build is running

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a build and check on staging looks perfect 😄 👍

@mmattel
Copy link
Contributor

mmattel commented Jan 10, 2023

When merged, I will backport the global adoc file to the stable docs branch.

@kobergj kobergj marked this pull request as ready for review January 11, 2023 08:20
@kobergj kobergj merged commit 8c2ebfd into owncloud:master Jan 11, 2023
@kobergj kobergj deleted the CollectGlobalEnvVars branch January 11, 2023 08:20
ownclouders pushed a commit that referenced this pull request Jan 11, 2023
Merge: 95023f2 a3bcb80
Author: kobergj <jkoberg@owncloud.com>
Date:   Wed Jan 11 09:20:17 2023 +0100

    Merge pull request #5369 from kobergj/CollectGlobalEnvVars

    Collect global Envvars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants