Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate expanded properties #5421

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Populate expanded properties #5421

merged 1 commit into from
Jan 18, 2023

Conversation

butonic
Copy link
Member

@butonic butonic commented Jan 18, 2023

We now return an empty array when an expanded relation has no entries. This makes consuming the responses a little easier.

fixes #5419

@update-docs
Copy link

update-docs bot commented Jan 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic force-pushed the populate-expanded-properties branch from c9cc6b1 to cf6bed5 Compare January 18, 2023 13:41
@butonic butonic marked this pull request as ready for review January 18, 2023 13:42
@butonic butonic force-pushed the populate-expanded-properties branch 2 times, most recently from 12d2b99 to 1a71459 Compare January 18, 2023 14:05
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

80.0% 80.0% Coverage
3.6% 3.6% Duplication

@butonic butonic merged commit 52b7f41 into master Jan 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the populate-expanded-properties branch January 18, 2023 14:51
ownclouders pushed a commit that referenced this pull request Jan 18, 2023
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Wed Jan 18 15:51:53 2023 +0100

    Populate expanded properties (#5421)

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$expand should always return the property, even for empty lists
2 participants