Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a global variable for the metadata backend #5680

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add a global variable for the metadata backend #5680

merged 1 commit into from
Feb 28, 2023

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Feb 28, 2023 •
edited
Loading

Description

The local envvars should have a common global envvar as we do with other services.

OCIS_DECOMPOSEDFS_METADATA_BACKEND; STORAGE_SYSTEM_OCIS_METADATA_BACKEND
and
OCIS_DECOMPOSEDFS_METADATA_BACKEND; STORAGE_USERS_OCIS_METADATA_BACKEND

Related Issue

Motivation and Context

Keep things consitent, quote from @butonic

That can be done in a subsequent PR.

How Has This Been Tested?

No code change

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@mmattel mmattel added the Category:Enhancement Add new functionality label Feb 28, 2023
@update-docs
Copy link

update-docs bot commented Feb 28, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 6290975 into master Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the add_global_envvar branch February 28, 2023 12:09
ownclouders pushed a commit that referenced this pull request Feb 28, 2023
@mmattel
commit 6290975
22f4bee 
Merge: bdbd70d f526326
Author: Martin <github@diemattels.at>
Date:   Tue Feb 28 13:09:31 2023 +0100

    Merge pull request #5680 from owncloud/add_global_envvar

    Add a global variable for the metadata backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmattel @kobergj