add new permission 'publiclink.create' and assign it to the 'Admin', … #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'SpaceAdmin' and 'User' roles
C0rby
force-pushed
the
create-public-link-permission
branch
from
4453ef8
to
b8470d5
Compare
|
💥 Acceptance test localApiTests-apiAsyncUpload-ocis failed. Further test are cancelled... |
|
SonarCloud Quality Gate failed.
|
kobergj
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Looks good 👍 But pipeline won't get green. See here: #5663 (comment)
No it will because you are not running full-ci 😃
|
Sonarcloud is failing because of the duplication. In this case this is necessary so I'll force merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new permission 'PublicLink.Write' to check if a user can create or update public links.