Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reva #5785

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Update reva #5785

merged 2 commits into from
Mar 9, 2023

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Mar 9, 2023

Fixed bugs in the password protected links feature and changed the status code when updating a space fails because of invalid arguments.

@C0rby C0rby requested a review from micbar March 9, 2023 15:10
@C0rby C0rby self-assigned this Mar 9, 2023
@C0rby C0rby requested a review from kobergj March 9, 2023 15:18
kobergj
kobergj previously requested changes Mar 9, 2023
View reviewed changes
changelog/unreleased/public-link-password.md Outdated Show resolved Hide resolved
services/sharing/pkg/revaconfig/config.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@C0rby C0rby requested a review from kobergj March 9, 2023 15:50
@C0rby C0rby dismissed kobergj’s stale review March 9, 2023 16:24

Everything was resolved

@C0rby C0rby merged commit 0f77aca into master Mar 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the update-reva branch March 9, 2023 16:25
ownclouders pushed a commit that referenced this pull request Mar 9, 2023
commit 0f77aca
b43b4bc 
Merge: 4218331 fcf958c
Author: David Christofas <dchristofas@owncloud.com>
Date:   Thu Mar 9 17:24:55 2023 +0100

    Merge pull request #5785 from owncloud/update-reva

    Update reva
@C0rby C0rby mentioned this pull request Mar 13, 2023
Closed
4 tasks
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@kobergj kobergj Awaiting requested review from kobergj

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @micbar @kobergj