Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Accept-Language Header #5918

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Use Accept-Language Header #5918

merged 1 commit into from
Mar 23, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 23, 2023

Use the widely accepted Accept-Language Header instead of the custom Prefered-Language one

kulmann
kulmann approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🤩

services/userlog/pkg/service/http.go Outdated Show resolved Hide resolved
@kobergj
use accept language header
0681cec 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj requested a review from butonic March 23, 2023 16:16
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit a3609e8 into owncloud:master Mar 23, 2023
ownclouders pushed a commit that referenced this pull request Mar 23, 2023
@micbar
Merge pull request #5918 from kobergj/UseCorrectLanguageHeader
6f95f33 
Use Accept-Language Header
@kobergj kobergj deleted the UseCorrectLanguageHeader branch March 24, 2023 08:14
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@micbar micbar micbar approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobergj @butonic @kulmann @micbar