[full-ci] add optional services and fix config slice parser #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
reviewed
Apr 18, 2023
butonic
reviewed
Apr 18, 2023
butonic
reviewed
Apr 18, 2023
butonic
reviewed
Apr 18, 2023
butonic
reviewed
Apr 18, 2023
micbar
force-pushed
the
fix-run-services
branch
from
b89c7c9
to
e16cc97
Compare
micbar
force-pushed
the
fix-run-services
branch
from
e16cc97
to
e73d549
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Apr 18, 2023
[full-ci] add optional services and fix config slice parser
This was referenced Apr 19, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: Add optional services to the runtime
Make it possible to start optional services in the ocis runtime. Instead of using
OCIS_RUN_SERVICESto define all services we can now useOCIS_ADD_RUN_SERVICESto add a comma separated list of additional services which are not started in the single process by default.Fix
Our envdecoder was parsing string slices differently than documented. It was using
;as a separator.@wkloucek @mmattel FYI
Motivation and Context
Make the usage of the single process runtime easier
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: