Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine the users preferred language to translate emails via Transi… #6089

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Determine the users preferred language to translate emails via Transi… #6089

merged 1 commit into from
Apr 24, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Apr 19, 2023

Determine the users preferred language to translate emails via Transifex.

Description

Related Issue

How Has This Been Tested?

  • test environment: local
  • test case 1: tested by existing test suite

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@2403905 2403905 requested a review from kobergj April 19, 2023 15:29
@2403905 2403905 requested a review from aduffeck April 20, 2023 08:01
kobergj
kobergj requested changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks. Rest looks awesome 👍

changelog/unreleased/users-preferred-language-email.md Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
@2403905 2403905 force-pushed the issue-6087 branch 6 times, most recently from b3d4458 to 550f028 Compare April 21, 2023 13:06
@2403905 2403905 requested a review from kobergj April 21, 2023 13:26
kobergj
kobergj approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small questions, not critical

services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
kobergj
kobergj requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change comment and rename owner -> executant

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

52.8% 52.8% Coverage
4.8% 4.8% Duplication

kobergj
kobergj approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@2403905 2403905 merged commit 5f4c068 into owncloud:master Apr 24, 2023
ownclouders pushed a commit that referenced this pull request Apr 24, 2023
@2403905
Merge pull request #6089 from 2403905/issue-6087
80230f1 
Determine the users preferred language to translate emails via Transi…
ownclouders pushed a commit that referenced this pull request Apr 24, 2023
@2403905
Merge pull request #6089 from 2403905/issue-6087
00a578d 
Determine the users preferred language to translate emails via Transi…
ownclouders pushed a commit that referenced this pull request Apr 24, 2023
@2403905
Merge pull request #6089 from 2403905/issue-6087
e95cc68 
Determine the users preferred language to translate emails via Transi…
ownclouders pushed a commit that referenced this pull request Apr 24, 2023
@2403905
Merge pull request #6089 from 2403905/issue-6087
07e9a99 
Determine the users preferred language to translate emails via Transi…
ownclouders pushed a commit that referenced this pull request Apr 24, 2023
@2403905
Merge pull request #6089 from 2403905/issue-6087
5d47999 
Determine the users preferred language to translate emails via Transi…
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@lookacat lookacat Awaiting requested review from lookacat

@aduffeck aduffeck Awaiting requested review from aduffeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determine the users preferred language to translate emails via Transifex.
2 participants
@2403905 @kobergj