[full-ci] Fix #4893: Make sure filenames (and extensions) are properly updated in file list and sidebar after rename

[dschmidt]

Description

Make sure filenames (and extensions) are properly updated in file list and sidebar after rename.

Related Issue

• Fixes Unexpected behavior when renaming files #4893

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[dschmidt]

I haven't added a test for the files list view, but there is one in this PR: https://github.com/owncloud/web/pull/6110/files

How do we go on with this? Should we merge them together before we merge to master? Or should we merge them sequentially?

[fschade]

looks good to me, 1 tiny fininding which is optional, thanks for taking care

[fschade]

I haven't added a test for the files list view, but there is one in this PR: https://github.com/owncloud/web/pull/6110/files

How do we go on with this? Should we merge them together before we merge to master? Or should we merge them sequentially?

It’s ok to not have a acceptance test in place, it’s verified in unit tests.

maybe @ScharfViktor wanna have in smoke tests do demonstrate basic file operations.

[pascalwengerter]

Restarted flaky smoke tests in CI, PR looks great to me!

[kulmann]

Awesome 👍

[ScharfViktor]

There is a failing in the same place. I will try running it locally, maybe there is a problem

[ScharfViktor]

again in the same place. running the tests locally was successful

[ownclouders]

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/20906/44/1
The following scenarios passed on retry:

• webUISharingExternalToRoot/federationSharing.feature:111

[pascalwengerter]

Last CI run had two failures (one flaky federation sharing test in OC10, one copying an empty file on oCIS). Rebased on master to resolve conflict, bumped oCIS commit ID once more and fixed the oCIS acceptance test. Should be fine now once we pass the flaky smoke tests

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

83.3% Coverage
0.0% Duplication

[ownclouders]

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20942/16/1
The following scenarios passed on retry:

• webUISharingAcceptSharesToRoot/acceptShares.feature:108

[ownclouders]

Results for oCISSharingPublic https://drone.owncloud.com/owncloud/web/20942/65/1
The following scenarios passed on retry:

• webUISharingPublicManagement/publicLinkIndicator.feature:110

[ownclouders]

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/20942/54/1
The following scenarios passed on retry:

• webUISharingAcceptShares/acceptShares.feature:111

[pascalwengerter]

Finally 🙏🏽

[dschmidt]

🎉