Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to ResourceTable #7388

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Add tags to ResourceTable #7388

merged 5 commits into from
Aug 4, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Aug 2, 2022

Description

See #7169
Needs: owncloud/owncloud-design-system#2284

Related Issue

Screenshots

Screenshot (21)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs
Copy link

update-docs bot commented Aug 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Aug 2, 2022

Results for oCISSharingAutocompletion https://drone.owncloud.com/owncloud/web/27341/63/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L73.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L73.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L74.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L74.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@lookacat lookacat marked this pull request as ready for review August 4, 2022 10:21
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
18.4% 18.4% Duplication

@lookacat lookacat requested review from kulmann, fschade and AlexAndBear and removed request for fschade August 4, 2022 10:43
@AlexAndBear
Copy link
Contributor

@lookacat can you change the target branch to experimental?

@lookacat lookacat changed the base branch from master to experimental August 4, 2022 11:18
@lookacat lookacat merged commit 7d2a424 into experimental Aug 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the tags-filestable branch August 4, 2022 13:01
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was merged without approval. 😛 ex post LGTM 👍 implementation looks really clean, good job.

@kulmann
Copy link
Member

kulmann commented Aug 5, 2022

Also, I set up branch protection on the experimental branch now.

fschade added a commit that referenced this pull request Aug 16, 2022
* change ocis to experimental
change sdk to experimental

* bump ocis commit id

* Add tags to ResourceTable (#7388)

* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS

* [full-ci] Tags (#7385)

Tags init

* Truncate tags (#7442)

Truncate tags

Co-authored-by: Paul Neubauer <paulneubauer@live.de>
Co-authored-by: Jan <jackermann@owncloud.com>
@lookacat
Copy link
Contributor Author

@kulmann sorry don't know why it happened :O at least I know have the YOLO Batch for GitHub

@kulmann
Copy link
Member

kulmann commented Sep 17, 2022

@kulmann sorry don't know why it happened :O at least I know have the YOLO Batch for GitHub

Perfect achievement to have. 😁

JammingBen pushed a commit that referenced this pull request Dec 5, 2022
* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS
JammingBen pushed a commit that referenced this pull request Dec 8, 2022
* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS
JammingBen pushed a commit that referenced this pull request Dec 9, 2022
* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS
fschade pushed a commit that referenced this pull request Dec 20, 2022
* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS
fschade pushed a commit that referenced this pull request Dec 21, 2022
* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS
fschade pushed a commit that referenced this pull request Dec 22, 2022
* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Tags in filelist
4 participants