Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Bump ocis commit id and middleware version #7413

Merged
merged 1 commit into from
Aug 8, 2022
Merged

[tests-only] Bump ocis commit id and middleware version #7413

merged 1 commit into from
Aug 8, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Aug 8, 2022 •
edited
Loading

Description

Related Issue

part of

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha self-assigned this Aug 8, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Aug 8, 2022 •
edited
Loading

Results for oC10Files4 https://drone.owncloud.com/owncloud/web/27388/20/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@amrita-shrestha amrita-shrestha mentioned this pull request Aug 8, 2022
Closed
14 tasks
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - gets improved middleware test code.

@phil-davis phil-davis merged commit b7da812 into master Aug 8, 2022
@phil-davis phil-davis deleted the bump-middleware-version branch August 8, 2022 07:58
@SwikritiT SwikritiT mentioned this pull request Aug 8, 2022
Merged
10 tasks
@SwikritiT
Copy link
Contributor

@amrita-shrestha Just a reminder for next time, usually for bumping PR we should run them with full-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @ownclouders @SwikritiT @phil-davis