Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Import owncloud-design-system #7940

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Nov 9, 2022

This PR imports the owncloud-design-system from owncloud/owncloud-design-system#2367 and renames it to @ownclouders/design-system, to be consistent with @ownclouders/web-pkg and @ownclouders/web-client.
It's built as part of the regular rollup dev server and production builds, so no separate build step is neccessary anymore.

The documentation built is unfortunately broken, but we decided to postpone fixing it a bit, as we still have to sort out publishing separate packages from our monorepo. We probably just need to make vue-styleguidist/webpack aware of TypeScript and everything should work again.

This PR is standing on shoulders of giants, mainly @pascalwengerter and @fschade.
Kudos for preparing https://github.com/owncloud/owncloud-design-system/pull/1888/files, took a lot of inspiration from that one.

Tasks

  • Make ODS build in Rollup with the rest of the application
  • Integrate Tests
  • Rename to @ownclouders/design-system
  • Cleanup

Followup Tasks

  • Check/migrate translations in transifex
  • Add documentation generation to .drone.star
  • Prepare Standalone Builds
  • Vite :)
  • Vue 3 :)

further reference

owncloud/owncloud-design-system@master...migrate-to-vue-3

@update-docs
Copy link

update-docs bot commented Nov 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter
Copy link
Contributor

@fschade @dschmidt this isn't in a usable state yet I reckon?

@dschmidt
Copy link
Member Author

dschmidt commented Nov 9, 2022

Kind of I guess, give it a try.

You need to run build:system and maybe need to restart rollup... but haven't tested it myself

@dschmidt dschmidt force-pushed the owncloud-design-system-workspace branch 2 times, most recently from ab52140 to 738ff38 Compare November 15, 2022 20:55
@dschmidt dschmidt changed the title Use owncloud-design-system from packages/ WIP: Import owncloud-design-system into our monorepo Nov 17, 2022
@dschmidt dschmidt changed the title WIP: Import owncloud-design-system into our monorepo [full-ci] Import owncloud-design-system into our monorepo Nov 17, 2022
@ownclouders
Copy link
Contributor

Results for oC10Files5 https://drone.owncloud.com/owncloud/web/29921/21/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesActionMenu-versions_feature-L15.png

webUIFilesActionMenu-versions_feature-L15.png

webUIFilesActionMenu-versions_feature-L26.png

webUIFilesActionMenu-versions_feature-L26.png

webUIFilesActionMenu-versions_feature-L46.png

webUIFilesActionMenu-versions_feature-L46.png

webUIFilesActionMenu-versions_feature-L74.png

webUIFilesActionMenu-versions_feature-L74.png

webUIFilesActionMenu-versions_feature-L90.png

webUIFilesActionMenu-versions_feature-L90.png

💥 The oC10Files5 tests pipeline failed. The build has been cancelled.

@dschmidt dschmidt force-pushed the owncloud-design-system-workspace branch 3 times, most recently from 92408cc to c1b806b Compare November 17, 2022 23:42
@dschmidt dschmidt changed the title [full-ci] Import owncloud-design-system into our monorepo [full-ci] Import owncloud-design-system Nov 17, 2022
@dschmidt dschmidt force-pushed the owncloud-design-system-workspace branch from c1b806b to e37f3c3 Compare November 17, 2022 23:42
@dschmidt dschmidt marked this pull request as ready for review November 17, 2022 23:50
@dschmidt dschmidt force-pushed the owncloud-design-system-workspace branch 2 times, most recently from ed7cb31 to 6079d5c Compare November 18, 2022 12:10
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes, so that this PR can't be merged accidentally. The design system has contradicting license information in its repo. There is a license file which states Apache2.0, and the package.json claims that its licensed under AGPL-3.0. Needs to be clarified before we can merge.

We consciously decided against importing the history: it's quite huge, contains a lot of bloat (e.g. UiKit assets) and because of the reformatting git blame is only useful with some effort.
@dschmidt dschmidt force-pushed the owncloud-design-system-workspace branch from 6079d5c to 5530b9b Compare November 21, 2022 15:32
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 11 Security Hotspots
Code Smell A 27 Code Smells

31.0% 31.0% Coverage
1.1% 1.1% Duplication

@kulmann
Copy link
Member

kulmann commented Nov 21, 2022

Requesting changes, so that this PR can't be merged accidentally. The design system has contradicting license information in its repo. There is a license file which states Apache2.0, and the package.json claims that its licensed under AGPL-3.0. Needs to be clarified before we can merge.

Has been clarified internally with @hodyroff - there was the idea of moving towards Apache2.0 in the design system, but apparently never executed completely/correctly and the CLA bot for the AGPL was always active. Moving the design system over to the web monorepo (= this PR) will revert the incomplete license transition back to AGPL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants