Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent self deletion #7958

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Prevent self deletion #7958

merged 7 commits into from
Dec 9, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 14, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Nov 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cover the differentiation in unit tests?

@dschmidt
Copy link
Member

The test for the Users component has changed a lot in #7877

I would kindly ask you to wait for that PR to land and adapt your PR afterwards. The Vue 2.7 PR is quite a beast and I'm happy it's green at last :)

@AlexAndBear
Copy link
Contributor Author

@dschmidt sure, can you ping me after its done?

@AlexAndBear
Copy link
Contributor Author

@kulmann sure! Done

@ownclouders
Copy link
Contributor

ownclouders commented Nov 16, 2022 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/30533/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/30533/tracing/folder-alice-2022-12-8-10-24-34.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/30533/tracing/folder-brian-2022-12-8-10-24-43.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/30533/tracing/upload-resources-in-personal-space-alice-2022-12-8-10-26-09.zip

💥 The e2e-oc10 tests pipeline failed. The build has been cancelled.

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Nov 16, 2022 •
edited
Loading

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/29889/37/1

The acceptance tests failed on retry. Please find the screenshots inside ...
The oC10SharingPublic2 tests pipeline failed. The build has been cancelled.

Ughhh, wasn't me

kulmann
kulmann requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a bugfix changelog item. Otherwise good to go 👍

kulmann
kulmann approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 90f1613 into master Dec 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7955 branch December 9, 2022 09:55
ownclouders pushed a commit that referenced this pull request Dec 9, 2022
commit 90f1613
17f403d 
Author: Jan <jackermann@owncloud.com>
Date:   Fri Dec 9 10:55:31 2022 +0100

    Prevent self deletion (#7958)
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting users along with admin shows failed in UI
4 participants
@AlexAndBear @dschmidt @ownclouders @kulmann