[full-ci] Access right sidebar panels via URL #8021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Nov 24, 2022
There was a problem hiding this comment.
Apparently we have the suffix -item in all panel names... IMO we should kill that 😆 Could you check if that's easily possible? And if not, then please omit the -item suffix from the query param and append it in the useScrollTo composable where you publish the event.
JammingBen
force-pushed
the
sidebar-panels-via-url
branch
from
5266ae8
to
1f402b8
Compare
JammingBen
force-pushed
the
sidebar-panels-via-url
branch
from
3adb672
to
a4cc2fc
Compare
JammingBen
force-pushed
the
sidebar-panels-via-url
branch
from
a4cc2fc
to
6c311e9
Compare
|
Results for oC10Files3 https://drone.owncloud.com/owncloud/web/30109/19/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesDetails-fileDetails_feature-L32.pngwebUIFilesDetails-fileDetails_feature-L70.png |
JammingBen
force-pushed
the
sidebar-panels-via-url
branch
from
6c311e9
to
9776a67
Compare
JammingBen
changed the title
JammingBen
force-pushed
the
sidebar-panels-via-url
branch
2 times, most recently
from
3739c28
to
845916b
Compare
JammingBen
force-pushed
the
sidebar-panels-via-url
branch
from
845916b
to
8806647
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Awesome! 🥳
@michaelstingl please see the changelog item for available panel names for the details query item for the private link
2 tasks
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening the right sidebar (including its panels) is now possible via URL param.
For private or internal links it only requires the new
detailsparam in the URL. For other URLs (e.g. personal space, project space) thescrollToparam including the resource id is needed as well.The following values can be used for the
detailsparam:details- sidebar open, no specific panelactions- actions panelsharing- share panelversions- versions panelspace-share- members panel (project space only)Note: "-item"-prefix for sidebar panels has been removed in the course of this.
Related Issue
Types of changes