Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text editor appearance #8026

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix text editor appearance #8026

merged 2 commits into from
Nov 28, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

The text editor now looks normal again after its appearance had changed due to the inclusion of the ODS in the web repository.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Nov 25, 2022
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vertical sizing seems to be broken, see screenshot (that's the lower left corner).

Screenshot 2022-11-25 at 16 24 13

@JammingBen
Copy link
Collaborator Author

@kulmann Do you mean there should be a margin-bottom because of the rounded corners? The inner container doesn't have a padding, so the textarea takes its full height - that was the same before.

@kulmann
Copy link
Member

kulmann commented Nov 28, 2022

@kulmann Do you mean there should be a margin-bottom because of the rounded corners? The inner container doesn't have a padding, so the textarea takes its full height - that was the same before.

The crisp edge of the text editor should be centered both horizontally and vertically in the rounded corner of the app content container.

@JammingBen
Copy link
Collaborator Author

Should be fine now:
image

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit afe4a04 into master Nov 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-text-editor-appearance branch November 28, 2022 11:16
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants