Disable reverting versions for read-only shares #8040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
commented
Nov 29, 2022
Comment on lines
+80
to
+86
| if (this.highlightedFile.permissions !== undefined) { | ||
| return this.highlightedFile.permissions.includes(DavPermission.Updateable) | ||
| } | ||
|
|
||
| if (this.highlightedFile.share?.role) { | ||
| return this.highlightedFile.share.role.hasPermission(SharePermissions.update) | ||
| } |
There was a problem hiding this comment.
Fyi: Both cases are needed unfortunately because highlightedFile can be a normal or a share resource. Maybe we should streamline all that permission-stuff some day... took me quite a while to get through all this.
JammingBen
force-pushed
the
disable-reverting-versions-for-read-only-shares
branch
from
0200140
to
c49bd42
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Nov 30, 2022
dschmidt
approved these changes
Nov 30, 2022
delete-merged-branch
bot
deleted the
disable-reverting-versions-for-read-only-shares
branch
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverting versions for read-only shares is no longer possible.
Related Issue
Types of changes