Fix resolving drives in search results #8045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix-resolving-drives-in-search
branch
from
ee03c14
to
7fbd0a8
Compare
JammingBen
force-pushed
the
fix-resolving-drives-in-search
branch
from
7fbd0a8
to
d63d8b5
Compare
kulmann
requested changes
Nov 30, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
kulmann
reviewed
Dec 1, 2022
| @@ -348,6 +353,10 @@ export default defineComponent({ | |||
| ]), | |||
|
|
|||
| async performLoaderTask(sameRoute: boolean, path?: string, fileId?: string | number) { | |||
| if (this.loadResourcesTask.isRunning) { | |||
There was a problem hiding this comment.
For the record: If space and item (= relative item path in that space) both changed, the loader task is called twice. This is skipping one of the task executions.
AlexAndBear
approved these changes
Dec 1, 2022
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed a bug where folder listing was not reloaded when being in a space/share root and navigating into another space/share root via search.
Related Issue
Types of changes