Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Enhancement: Show text file icon for empty text files #8057

Merged
merged 7 commits into from
Dec 12, 2022
Merged

[full-ci] Enhancement: Show text file icon for empty text files #8057

merged 7 commits into from
Dec 12, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Dec 1, 2022

Description

When having an almost empty txt file the thumbnail shows just a white square which looks weird.
We now replaced the thumbnail with the txt file icon for almost empty files.

Motivation and Context

Make UI not look bugged

Screenshots (if appropriate):

Before (all empty)
empty

After (all empty have txt file icon, the one with content displays a thumbnail)
after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat force-pushed the enhancement-show-txt-icon-for-empty-txt-files branch from ae38758 to caa3b6f Compare December 1, 2022 14:15
@lookacat lookacat changed the title Enhancement: Show text file icon for empty text files [full-ci] Enhancement: Show text file icon for empty text files Dec 1, 2022
@lookacat lookacat force-pushed the enhancement-show-txt-icon-for-empty-txt-files branch from caa3b6f to 7242496 Compare December 1, 2022 14:15
@lookacat lookacat marked this pull request as ready for review December 1, 2022 14:15
@ownclouders
Copy link
Contributor

ownclouders commented Dec 1, 2022 •
edited
Loading

Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/30292/23/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingExpirationDate-shareWithExpirationDate_feature-L14.png

webUISharingExpirationDate-shareWithExpirationDate_feature-L14.png

webUISharingExpirationDate-shareWithExpirationDate_feature-L21.png

webUISharingExpirationDate-shareWithExpirationDate_feature-L21.png

@lookacat lookacat requested a review from kulmann December 9, 2022 15:08
@lookacat lookacat requested a review from kulmann December 9, 2022 15:55
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit c3f0482 into master Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the enhancement-show-txt-icon-for-empty-txt-files branch December 12, 2022 13:49
ownclouders pushed a commit that referenced this pull request Dec 12, 2022
@lookacat
commit c3f0482
ef685e9 
Author: Paul Neubauer <paulneubauer@live.de>
Date:   Mon Dec 12 14:48:57 2022 +0100

    [full-ci] Enhancement: Show text file icon for empty text files (#8057)
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @ownclouders @kulmann