Feature: #8134 - copy to clipboard #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| const { | ||
| copy, | ||
| copied, | ||
| isSupported: isClipboardCopySupported |
There was a problem hiding this comment.
@JammingBen not sure if isSupported is needed here/in general in the v-ifs. I didn't look into it any further but as pointed out in #8136 (comment), from a cursory glance it is always true since we set legacy: true in useClipboard
There was a problem hiding this comment.
@dschmidt and I decided to leave it for now, as we are not 100% sure if needed or not (same as you :) )
dschmidt
approved these changes
Jan 2, 2023
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31085/68/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png |
JammingBen
force-pushed
the
feature/8134
branch
from
d904135
to
d0f8caf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Superseds #8136
Types of changes