Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the spaces list in the admin settings #8178

Merged
merged 11 commits into from
Jan 5, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 3, 2023

Description

Implements the basic list of spaces in the admin settings. The list is read-only currently, actions and sidebar will come in a follow-up PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

To-Dos

  • Basic list
  • List space member names (done in Web, but there is still a bug in oCIS)
  • Resolve groups to display user names as well -> needs discussion if needed, currently this is not possible
  • Unit tests
  • e2e tests
  • Changelog item

@JammingBen JammingBen self-assigned this Jan 3, 2023
@owncloud owncloud deleted a comment from update-docs bot Jan 4, 2023
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31162/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31162/tracing/spaces-can-be-listed-in-the-admin-settings-alice-2023-1-4-03-10-28.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31162/tracing/spaces-can-be-listed-in-the-admin-settings-brian-2023-1-4-03-10-32.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.8% 80.8% Coverage
6.9% 6.9% Duplication

@JammingBen JammingBen marked this pull request as ready for review January 4, 2023 15:55
@JammingBen
Copy link
Collaborator Author

Okay, so the basic (read-only) functionality works as expected, including unit- & e2e-tests. We still have a bug in oCIS where the displayName for space members is empty. @fschade will tackle this within the next few days - until then, the Manager column is empty.

Two acceptance criteria can't be fulfilled right now:

  • The column Created is missing because backend does not provide this kind of information.
  • Group members can't be resolved into single users as of now, hence each group counts as one. The backend does not support resolving groups currently, and Web can't do requests for each possible group. We may need to re-think that, and if it's still something we want, we need to come up with a solution in backend first. That would need some general concepting though.

@tbsbdr @kulmann fyi

@AlexAndBear AlexAndBear self-requested a review January 4, 2023 20:01
@delete-merged-branch delete-merged-branch bot deleted the branch master January 5, 2023 11:11
@JammingBen JammingBen changed the base branch from rename-user-management to master January 5, 2023 11:11
@JammingBen JammingBen merged commit c71bf1e into master Jan 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the admin-settings-spaces-list branch January 5, 2023 11:11
@fschade
Copy link
Collaborator

fschade commented Jan 5, 2023

@JammingBen JammingBen mentioned this pull request Jan 30, 2023
5 tasks
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants