Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple clients in theme.json #8280

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Add support for multiple clients in theme.json #8280

merged 4 commits into from
Jan 20, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 19, 2023 •
edited by micbar
Loading

Description

The theme.json file now supports multiple clients which are defined via the top-level property. Therefore both web themes have been moved down one level into the new property "web". The change is backwards compatible though, meaning it still works when the web themes are defined top-level in theme.json.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jan 19, 2023
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31881/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31881/tracing/copy-and-move-resources-in-personal-space-alice-2023-1-19-03-11-19.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the support-multiple-clients-in-theme-json branch from c085fc8 to 8fdaff1 Compare January 20, 2023 07:40
@micbar micbar force-pushed the support-multiple-clients-in-theme-json branch from 4dffd9b to e3772ad Compare January 20, 2023 14:27
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

micbar
micbar approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micbar micbar merged commit 51b5fa2 into master Jan 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the support-multiple-clients-in-theme-json branch January 20, 2023 15:20
ownclouders pushed a commit that referenced this pull request Jan 20, 2023
@micbar
commit 51b5fa2
8c8ba16 
Merge: c501c79 e3772ad
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Jan 20 16:20:52 2023 +0100

    Merge pull request #8280 from owncloud/support-multiple-clients-in-theme-json

    Add support for multiple clients in `theme.json`
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @micbar