Fix space member panel issues #8300

JammingBen · 2023-01-24T07:29:40Z

Description

Fix re-loading the space members panel
Fix disappearing groups after removing one group form a space

Related Issue

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

JammingBen · 2023-01-24T07:32:27Z

packages/web-app-files/src/components/SideBar/SideBar.vue

@@ -219,6 +220,9 @@ export default defineComponent({
        this.isSharedWithOthersLocation ||
        this.isSharedViaLinkLocation
      )
+    },
+    spaceResource() {
+      return this.spaces.find((s) => s.id === this.highlightedFile.id)


Again it makes it so much more complicated that the sidebar sometimes uses the highlightedFile for showing and mutating resources, sometimes we use the provided displayedItem, and now sometimes the spaceResource. It would be so nice to have that reduced to one provided prop (either via provide or via props).

fully agree 😕 I'm in favour of provide/inject for the data context of the sidebar. With props it'd be a pretty heavy cascade in some cases.

JammingBen · 2023-01-24T07:33:46Z

packages/web-runtime/src/store/spaces.ts

@@ -88,8 +88,10 @@ const mutations = {
    state.spaceMembers = members
  },
  UPSERT_SPACE_MEMBERS(state, member) {
+    // group shares don't have the name prop... distinguish by shareType


Distinction by shareType would be ideal, but I don't know if we need the server to adjust as well. Because the server currently handles space user- and group-shares via the same shareType: 7.