Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context menu to groups #8317

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Add context menu to groups #8317

merged 5 commits into from
Jan 25, 2023

Conversation

JammingBen
Copy link
Collaborator

Description

A context menu has been added to the groups management page in the admin settings. It can be toggled via right-click and quick-action.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jan 25, 2023
@JammingBen JammingBen mentioned this pull request Jan 25, 2023
Merged
5 tasks
kulmann
kulmann approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick. Good stuff, thanks for cleanup bonus round! ❤️

packages/web-app-admin-settings/src/mixins/groups/delete.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.2% 75.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 1d965d9 into master Jan 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-context-menu-for-groups branch January 25, 2023 16:04
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Groups: Add context menu
2 participants
@JammingBen @kulmann