Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init admin settings general appearance section #8375

Merged
merged 27 commits into from
Feb 9, 2023
Merged

Init admin settings general appearance section #8375

merged 27 commits into from
Feb 9, 2023

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 6, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Feb 8, 2023 •
edited
Loading

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/32621/72/1
💥 The oCISTrashbinJourney tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear marked this pull request as ready for review February 8, 2023 13:56
@AlexAndBear
Copy link
Contributor Author

Stupid sonarCloud.... demanding on imports are conditions that have to be covered -.-

@JammingBen
Copy link
Collaborator

JammingBen commented Feb 8, 2023 •
edited
Loading

I probably need some oCIS branch checked out to make it work...? Because uploading does not work for me.

Stupid sonarCloud.... demanding on imports are conditions that have to be covered -.-

Yeah, that's super annoying :( Especially with the composition API I feel that SonarCloud does a terrible job analyzing coverage.

@ownclouders
Copy link
Contributor

ownclouders commented Feb 9, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32647/75/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear mentioned this pull request Feb 9, 2023
Closed
@AlexAndBear AlexAndBear force-pushed the admin-settings-general-appearance branch from c63b5e3 to da92af2 Compare February 9, 2023 19:01
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.0% 62.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kulmann kulmann merged commit fbf9b89 into master Feb 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the admin-settings-general-appearance branch February 9, 2023 22:00
ownclouders pushed a commit that referenced this pull request Feb 9, 2023
commit fbf9b89
2e62a35 
Author: Jan <jackermann@owncloud.com>
Date:   Thu Feb 9 23:00:46 2023 +0100

    Init admin settings general appearance section (#8375)
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @ownclouders @JammingBen @kulmann