Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Spaces/User admin list edit quota batch actions #8387

Merged
merged 15 commits into from
Feb 14, 2023
Merged

[full-ci] Spaces/User admin list edit quota batch actions #8387

merged 15 commits into from
Feb 14, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 7, 2023 •
edited
Loading

Description

See #8417

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Followup test coverage PR / e2e tests

@update-docs
Copy link

update-docs bot commented Feb 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the spaces-edit-quota-batch-actions branch from 4b91248 to 7ac9836 Compare February 8, 2023 11:08
@lookacat lookacat marked this pull request as ready for review February 13, 2023 08:41
@lookacat lookacat changed the title Spaces/User admin list edit quota batch actions [full-ci] Spaces/User admin list edit quota batch actions Feb 13, 2023
@AlexAndBear AlexAndBear self-requested a review February 13, 2023 10:21
@lookacat lookacat force-pushed the spaces-edit-quota-batch-actions branch from eb76647 to 4647019 Compare February 13, 2023 15:05
@ownclouders
Copy link
Contributor

ownclouders commented Feb 13, 2023 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/32740/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32740/tracing/spaces-can-be-managed-in-the-admin-settings-alice-2023-2-13-04-39-42.zip

@fschade
Copy link
Collaborator

fschade commented Feb 13, 2023

@lookacat needs rebase

@lookacat lookacat force-pushed the spaces-edit-quota-batch-actions branch from 5cc9730 to 2063b9d Compare February 13, 2023 16:08
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

58.6% 58.6% Coverage
7.7% 7.7% Duplication

JammingBen
JammingBen approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks left from my side. Approving anyways since you do a follow-up, but please tackle them then 🙂

packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue Show resolved Hide resolved
packages/web-app-admin-settings/src/views/Spaces.vue Show resolved Hide resolved
packages/web-app-files/src/components/Spaces/SpaceContextActions.vue Show resolved Hide resolved
packages/web-pkg/src/mixins/spaces/editQuota.ts Show resolved Hide resolved
@lookacat lookacat merged commit 40598d2 into master Feb 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the spaces-edit-quota-batch-actions branch February 14, 2023 11:26
@lookacat lookacat mentioned this pull request Feb 15, 2023
Merged
10 tasks
kulmann pushed a commit that referenced this pull request Feb 15, 2023
@lookacat
#8387 Spaces/User admin list edit quota batch actions - Followup (#8438)
fe151df
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade left review comments

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lookacat @ownclouders @fschade @AlexAndBear @JammingBen