Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Show bell based on capabilities #8450

Merged
merged 8 commits into from
Feb 16, 2023
Merged

[full-ci] Show bell based on capabilities #8450

merged 8 commits into from
Feb 16, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 16, 2023 •
edited
Loading

Description

See changelog

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat changed the title Notification bell capabilities Show bell based on capabilities Feb 16, 2023
@lookacat lookacat marked this pull request as ready for review February 16, 2023 11:23
@ownclouders
Copy link
Contributor

ownclouders commented Feb 16, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32876/42/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUINotifications-displayNotificationsOnWebUI_feature-L18.png

webUINotifications-displayNotificationsOnWebUI_feature-L18.png

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32860/42/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUINotifications-displayNotificationsOnWebUI_feature-L18.png

webUINotifications-displayNotificationsOnWebUI_feature-L18.png

💥 The oC10Notification tests pipeline failed. The build has been cancelled.

@lookacat lookacat changed the title Show bell based on capabilities [full-ci] Show bell based on capabilities Feb 16, 2023
@lookacat lookacat force-pushed the notification-bell-capabilities branch from ecb14cb to cc07c9f Compare February 16, 2023 13:26
kulmann
kulmann previously requested changes Feb 16, 2023
View reviewed changes
packages/web-runtime/src/components/Topbar/Notifications.vue Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-notification-bell Outdated Show resolved Hide resolved
@pascalwengerter
Copy link
Contributor

@lookacat could you check whether this also closes #2968? :)

@kulmann kulmann mentioned this pull request Feb 16, 2023
Closed
@lookacat
Copy link
Contributor Author

@pascalwengerter yes good finding, indeed it does!

JammingBen
JammingBen approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat dismissed kulmann’s stale review February 16, 2023 14:53

fixed it, dismissed to merge :)

@lookacat lookacat merged commit b6dcf62 into master Feb 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the notification-bell-capabilities branch February 16, 2023 14:53
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Show bell based on capabilities Always show notifications bell
5 participants
@lookacat @ownclouders @pascalwengerter @kulmann @JammingBen