Update CERN links #8473
Merged
Update CERN links #8473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diocas
force-pushed
the
up_sambaeoslinks_fix
branch
2 times, most recently
from
aa4a382
to
d650c66
Compare
diocas
force-pushed
the
up_sambaeoslinks_fix
branch
from
d650c66
to
ade8cf5
Compare
kulmann
reviewed
Mar 1, 2023
| }) | ||
| } | ||
|
|
||
| const getSambaPath = (path) => { | ||
| const pathComponents = path?.split('/').filter(Boolean) |
There was a problem hiding this comment.
Can you please define the pathMappings inline here instead of having them in their own file? Completely CERN specific, so a dedicated file is probably more confusing than just having it inline here.
There was a problem hiding this comment.
Done, please let me know if it needs to be somewhere else. Also rebased to latest upstream.
diocas
force-pushed
the
up_sambaeoslinks_fix
branch
from
ade8cf5
to
1096612
Compare
|
Kudos, SonarCloud Quality Gate passed! |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the links displayed in the sidebar for CERN's deployment.