Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bugfix: Copy/Cut/Paste, paste shortcut doesn't trigger sometimes #8480

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 20, 2023

Description

See #8462

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat changed the title Bugfix: Copy/Cut/Paste, paste shortcut doesn't trigger sometimes [full-ci] Bugfix: Copy/Cut/Paste, paste shortcut doesn't trigger sometimes Feb 20, 2023
@lookacat lookacat marked this pull request as ready for review February 20, 2023 11:11
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -400,7 +400,7 @@ importers:
rollup-plugin-node-polyfills: 0.2.1
rollup-plugin-serve: 2.0.2
sass: 1.58.0
vite: 4.1.1
vite: 4.1.1_sass@1.58.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated, but happens for me as well when I do pnpm install on a clean master. So it's fine I guess 🤷

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 666a69d into master Feb 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix-paste-not-working branch February 20, 2023 12:08
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/Cut/Paste, paste shortcut doesn't trigger sometimes
2 participants