Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar share issues #8482

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Fix sidebar share issues #8482

merged 3 commits into from
Feb 22, 2023

Conversation

JammingBen
Copy link
Collaborator

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Feb 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

56.2% 56.2% Coverage
0.0% 0.0% Duplication

lookacat
lookacat approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@JammingBen JammingBen merged commit 96575cf into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-sidebar-share-issues branch February 22, 2023 13:30
@tbsbdr tbsbdr mentioned this pull request Jun 26, 2023
Closed
37 tasks
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
Early-Adopter:CERN Platform:Web
Projects
None yet
Milestone
CERN Web Merge
4 participants
@JammingBen @lookacat @AlexAndBear @tbsbdr