Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Init trash overview #8515

Merged
merged 39 commits into from
Mar 7, 2023
Merged

[full-ci] Init trash overview #8515

merged 39 commits into from
Mar 7, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 1, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 1, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Mar 1, 2023

@ownclouders
Copy link
Contributor

ownclouders commented Mar 1, 2023

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/33385/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33385/tracing/user-login-can-be-managed-in-the-admin-settings-admin-2023-3-7-12-25-08.zip

@AlexAndBear AlexAndBear marked this pull request as ready for review March 1, 2023 16:08
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the padding on the left side between the sidebar and the icon is a bit small on the first glance but just my opinion otherwise fine 👍🏼

@AlexAndBear AlexAndBear requested a review from kulmann March 2, 2023 14:24
@JammingBen
Copy link
Collaborator

Few annotations from my side, some things may be for a follow-up:

  • The padding to the left sidebar seems to be very small. Maybe align it vertically with the search input?
  • I'd prefer the sorting to be persisted via query param and local storage (just like in the regular file table). Also, sometimes the sorting does not work 🤔 But I can't reproduce that on a regular basis.
  • Searching gives me a weird blank after the marked characters:

image

Out of curiosity: Why did you remove the "Navigate to space" breadcrumb action? I found that quite useful actually.

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/router/trash.ts Outdated Show resolved Hide resolved
packages/web-app-files/src/views/trash/Overview.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/trash/Overview.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/trash/Overview.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/trash/Overview.vue Outdated Show resolved Hide resolved
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💪 🗑️

@kulmann kulmann changed the title Init trash overview [full-ci] Init trash overview Mar 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented Mar 7, 2023

Force merging. An unrelated e2e test failed in the login step due to a timeout.

@kulmann kulmann merged commit 0ea5c94 into master Mar 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the trashbin-list branch March 7, 2023 12:48
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web] Consistent Trashbin navigation
5 participants