[full-ci] Refactor notifications and make them work with oCIS #8518
Conversation
JammingBen
changed the title
JammingBen
changed the title
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/33284/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33284/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-3-3-07-07-42.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33284/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-3-3-07-08-12.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33284/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-3-3-07-08-18.zip |
JammingBen
force-pushed
the
ocis-notifications
branch
4 times, most recently
from
0c6b3d5
to
23944f2
Compare
JammingBen
force-pushed
the
ocis-notifications
branch
from
c13b609
to
aafe737
Compare
| const setAdditionalData = () => { | ||
| loading.value = true | ||
| for (const notification of unref(notifications)) { | ||
| notification.computedMessage = getMessage(notification) | ||
| notification.computedLink = getLink(notification) | ||
| } | ||
| loading.value = false | ||
| } |
There was a problem hiding this comment.
I decided to separate the additional data from the fetchNotificationsTask and only load it when the notifications drop menu is open. The reason behind this is because I don't know how expensive it will get with a bunch of notifications. Web polls notifications actively every 30 seconds, there is no need to load additional data every time.
I don't see any disadvantages with that approach, but I also don't now if it's necessary. Feedback welcome!
There was a problem hiding this comment.
Sounds like a good idea indeed 👍 let's do it like that.
JammingBen
force-pushed
the
ocis-notifications
branch
from
aafe737
to
002479e
Compare
JammingBen
force-pushed
the
ocis-notifications
branch
from
002479e
to
22d3dfb
Compare
|
Status: currently waiting for the backend to finish the rest of the implementation. Edit: Ready now! Needs owncloud/ocis#5699 though. |
|
Kudos, SonarCloud Quality Gate passed! |
Needs owncloud/ocis#5699.
Currently known issues on the backend side:Timestamps always show the current timeshare removednotification does not work yet (showsremoved from spaceevent instead)space deletednotification does not work yetCapabilities are missingRelated Issue
Screenshots
Types of changes
To-Dos: